[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#31641: 26.1; iter-do variable not left unused warning
|
From: |
Basil L. Contovounesios |
|
Subject: |
bug#31641: 26.1; iter-do variable not left unused warning |
|
Date: |
Fri, 05 Feb 2021 17:12:15 +0000 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Lars Ingebrigtsen <larsi@gnus.org> writes:
> diff --git a/lisp/emacs-lisp/generator.el b/lisp/emacs-lisp/generator.el
> index 9eb6d95964..0b644cc72c 100644
> --- a/lisp/emacs-lisp/generator.el
> +++ b/lisp/emacs-lisp/generator.el
> @@ -731,7 +731,10 @@ iter-do
> (,it-symbol ,iterator))
> (while (not ,done-symbol)
> (condition-case ,condition-symbol
> - (setf ,var (iter-next ,it-symbol))
> + ;; Variables that start with an underscore shouldn't be set.
> + ,(if (string-match-p "\\`_" (symbol-name var))
> + nil
> + `(setf ,var (iter-next ,it-symbol)))
Nit - AKA the following?
,(unless (string-prefix-p "_" (symbol-name var))
`(setf ,var (iter-next ,it-symbol)))
--
Basil