[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#45934: native-comp - Dylib ID of ELN files not optimal
From: |
Andrea Corallo |
Subject: |
bug#45934: native-comp - Dylib ID of ELN files not optimal |
Date: |
Fri, 29 Jan 2021 08:52:17 +0000 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Eli Zaretskii <eliz@gnu.org> writes:
>> Date: Thu, 28 Jan 2021 21:59:16 +0000
>> Cc: 45934@debbugs.gnu.org
>> From: akrl--- via "Bug reports for GNU Emacs,
>> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>>
>> +/* On MacOS set a unique dylib ID (Bug#45934). */
>> +#if defined (LIBGCCJIT_HAVE_gcc_jit_context_add_driver_option) \
>> + && defined (DARWIN_OS)
>> + gcc_jit_context_add_driver_option (
>> + comp.ctxt,
>> + SSDATA (concat2 (build_string ("-install_name "),
>> + Ffile_name_nondirectory (filename))));
>> +#endif
>
> A minor nit unrelated to the issue at hand: if you take care to
> mention the bug number in the commit log message, there's no need to
> do that in the comments.
>
> In general, I don't think it's a good idea to have our sources full of
> references to bug reports; if the comment by itself doesn't explain
> the underlying issue, it is better to enhance the comment to be
> self-contained. IMO, a reference to a bug in the comments is only
> justified when the issue is so complicated to explain that having such
> an explanation in comments is impractical.
>
> TIA
SGTM, I'll update the patch at the next iteration or before pushing it.
Thanks
Andrea
- bug#45934: native-comp - Dylib ID of ELN files not optimal, Davide Restivo, 2021/01/17
- bug#45934: native-comp - Dylib ID of ELN files not optimal, Andrea Corallo, 2021/01/17
- bug#45934: native-comp - Dylib ID of ELN files not optimal, Davide Restivo, 2021/01/17
- bug#45934: native-comp - Dylib ID of ELN files not optimal, Andrea Corallo, 2021/01/17
- bug#45934: native-comp - Dylib ID of ELN files not optimal, Davide Restivo, 2021/01/23
- bug#45934: native-comp - Dylib ID of ELN files not optimal, Andrea Corallo, 2021/01/24
- bug#45934: native-comp - Dylib ID of ELN files not optimal, Andrea Corallo, 2021/01/28
- bug#45934: native-comp - Dylib ID of ELN files not optimal, Eli Zaretskii, 2021/01/29
- bug#45934: native-comp - Dylib ID of ELN files not optimal,
Andrea Corallo <=
- bug#45934: native-comp - Dylib ID of ELN files not optimal, Davide Restivo, 2021/01/30