[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#18093: [External] : Re: bug#18093: 24.4.50; `delsel.el' fixes for us
From: |
Drew Adams |
Subject: |
bug#18093: [External] : Re: bug#18093: 24.4.50; `delsel.el' fixes for use with `completion.el' |
Date: |
Sun, 24 Jan 2021 00:52:24 +0000 |
> > `delsel.el' should be updated to play well with library `completion.el'.
> > The following should be done (or equivalent):
> >
> > 1.
> > (put 'completion-separator-self-insert-command 'delete-selection t)
> > (put 'completion-separator-self-insert-autofilling 'delete-selection t)
> >
> > 2. If `last-command' is `complete' and `this-command' has
> > `delete-selection' property `supersede' or `kill', replace the last
> > inserted completion with the string that was completed.
> >
> > (defun delete-active-region (&optional killp)
> > (cond ((and (eq last-command 'complete) ; See `completion.el'.
> > (boundp 'cmpl-last-insert-location))
>
> As far as I can tell, 1) doesn't exist any more, and I'm not quite sure
> I understand 2) (I've never used delsel mode).
>
> Is this something that still needs work, or has what this bug report is
> about been fixed in the years since it was filed?
Yes, Emacs 25 changed `completion.el' in this regard
when it ___ed `delsel.el' in order to accommodate
electric whatever (`electric--after-char-pos' seems
to be the place that `completion.el' was affected.
I have no idea anymore what needs to be done now,
to fix the problems reported by this bug. Sorry.
Someone familiar with the changes made to `delsel.el'
and `completion.el' back in Emacs 25 for accommodating
whatever electric toy was involved will need to take
a look.
This is what happens when someone adds a feature
(or even fixes a bug) without paying attention to
outstanding bugs reported for the code they modify.
(One can presume that's what happened, else this bug
would have been closed one way or another.)