[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#42425: 26.3.50; Compilation warnings when compiling eldoc.el under E
From: |
Lars Ingebrigtsen |
Subject: |
bug#42425: 26.3.50; Compilation warnings when compiling eldoc.el under Emacs 26.3 |
Date: |
Sat, 23 Jan 2021 19:31:27 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Philipp Stephani <p.stephani2@gmail.com> writes:
>> Doing so seems easy enough, but I'm not sure how high our ambitions are
>> for doing warning-free ELPA packages on older Emacs versions? (I've
>> added João to the CCs.)
>
> I think our ambitions should be quite high. (I personally think we
> should treat almost all compiler warnings as errors/bugs and fix them
> whenever realistically possible.)
Building Emacs has traditionally been watching a wall of warnings scroll
by. This has recently changed, but shows that "no warnings" isn't a
value held universally by the Emacs developers.
I think that the Emacs build should be warning free -- on our main,
current targets. Jumping through hoops to avoid warnings on older Emacs
versions normally isn't worth spending time on, in my opinion.
But we really have no policy here.
>> > 2. Probably eldoc should protect against newer Elisp functions being not
>> > yet available, as calling such functions will likely result in errors
>> > at runtime.
>>
>> Doesn't it do that? What functions is it using that's not available?
>
> At least the current master version looks fine, though the byte
> compiler isn't smart enough to detect that. The problematic uses are
> in eldoc--eval-expression-setup.
I'm not sure I follow you here -- are you saying that eldoc doesn't work
on Emacs 26 because of the usages in `eldoc--eval-expression-setup'?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no