[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompat
From: |
Protesilaos Stavrou |
Subject: |
bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible) |
Date: |
Thu, 10 Dec 2020 09:57:46 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
On 2020-12-09, 15:58 -0600, Stefan Kangas <stefankangas@gmail.com> wrote:
> "Basil L. Contovounesios" <contovob@tcd.ie> writes:
>
>>> Those are the issues I could identify. As such, the attached patch
>>> removes the old files and places the new ones in ../lisp/modus-themes/.
>>> The themes' manual is updated to cover the new version. The NEWS entry
>>> is edited accordingly.
>>>
>>> I understand you may object to the course of action covered by the
>>> patch. Please inform me of a better way to address this issue. My
>>> intent is to contribute version 1.0 of my themes to Emacs (1.0.2 to be
>>> precise) and am prepared to make the requisite changes based on your
>>> feedback.
>>
>> FWIW, I'd sooner make the infrastructure changes needed to make themes
>> under etc/themes/ more modular and package-like, than start moving them
>> out of etc/themes/.
>>
>> Otherwise, I'd expect themes under lisp/ to behave exactly like those
>> under etc/themes/, which would make the etc/themes/ directory redundant.
>> (Maybe we need a lisp/themes/ directory?)
>
> Yes, I think if we start adding a number of these themes under
> "lisp/<foo>-theme/" it risks getting messy over time.
>
> Would it make sense to just add a "lisp/themes" directory, as Basil
> suggests, containing the new files modus-themes-core.el and
> modus-themes.el?
>
> That way, I assume that we can just keep the themes in "etc/themes" for
> now, while any theme that needs it can put its support libraries in
> "lisp/themes". Does that make sense? Would it work without any changes
> to load-theme?
Thank you Stefan and Basil!
I agree that putting them all under lisp/ is not the right way to go
right now. Today I will experiment with placing the libraries in
lisp/themes and the derivatives in etc/themes. This will obfuscate the
source code though, but I will try nonetheless and report back to you
(without prejudice to any other ideas you or someone else may have).
--
Protesilaos Stavrou
protesilaos.com
- bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible), Protesilaos Stavrou, 2020/12/06
- bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible), Basil L. Contovounesios, 2020/12/08
- bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible), Stefan Kangas, 2020/12/09
- bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible),
Protesilaos Stavrou <=
- bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible), Stefan Kangas, 2020/12/10
- bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible), Protesilaos Stavrou, 2020/12/10
- bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible), Juri Linkov, 2020/12/11
- bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible), Stefan Kangas, 2020/12/11
- bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible), Eli Zaretskii, 2020/12/11
- bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible), Stefan Kangas, 2020/12/11
- bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible), Christopher Dimech, 2020/12/11
- bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible), Eli Zaretskii, 2020/12/11
- bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible), Stefan Kangas, 2020/12/11
- bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible), Eli Zaretskii, 2020/12/11