bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#44980: [PATCH] Fix test for failed uses of lexical vars in byte-comp


From: Stefan Kangas
Subject: bug#44980: [PATCH] Fix test for failed uses of lexical vars in byte-compiler
Date: Mon, 30 Nov 2020 21:17:41 -0600

Severity: minor

Hi Stefan,

In 2015, you added this:

commit ad5a7c86d017ce8e9ff1312331ef09181be823bf
Author: Stefan Monnier <monnier@iro.umontreal.ca>
Date:   Thu Feb 5 14:28:16 2015 -0500

[...]
    (byte-compile-form): Add warnings for failed uses of lexical vars via
    quoted symbols.

However, the test uses `assq' to check `byte-compile-lexical-variables',
but that is not an alist.  It seems to me that the correct test would
use `memq'.

Please see the attached patch that fixes this.  It also adds tests.

WDYT?  Am I missing something?

Attachment: 0001-Fix-test-for-failed-uses-of-lexical-vars-in-byte-com.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]