[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#44424: [PATCH] 28.0.50; Use bespoke face for commit message in vc-pr
|
From: |
Dmitry Gutov |
|
Subject: |
bug#44424: [PATCH] 28.0.50; Use bespoke face for commit message in vc-print-root-log |
|
Date: |
Sat, 28 Nov 2020 20:13:38 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 03.11.2020 19:23, Protesilaos Stavrou wrote:
What do you think?
I think the idea is good, but the change in the looks is a bit questionable.
Can we do it without the grey background? It's kind of weird to see it
surrounded by "unexpanded" log entries that use the default white
background. And other windows that mostly use the white background.
As we can see on the screenshots you posted yourself, the "before" one
looks more uniform than the "after".
If there are no alternative ideas on which colors to pick, we can just
inherit from font-lock-comment-face, to retain the previous looks.