[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#44676: [PATCH 3/4] Support native compilation of packages on install
From: |
Andrea Corallo |
Subject: |
bug#44676: [PATCH 3/4] Support native compilation of packages on install |
Date: |
Fri, 20 Nov 2020 09:06:23 +0000 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Stefan Kangas <stefan@marxist.se> writes:
> From bd570f03a3b3dcb546b02e83faf263f27e82d05c Mon Sep 17 00:00:00 2001
> From: Stefan Kangas <stefan@marxist.se>
> Date: Thu, 19 Nov 2020 22:11:17 +0100
> Subject: [PATCH 3/4] * lisp/emacs-lisp/comp.el (native-compile-async): Doc
> fix.
>
> ---
> lisp/emacs-lisp/comp.el | 25 ++++++++++++++++++++-----
> 1 file changed, 20 insertions(+), 5 deletions(-)
>
> diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el
> index a9a07535a4..e48a1cfc18 100644
> --- a/lisp/emacs-lisp/comp.el
> +++ b/lisp/emacs-lisp/comp.el
> @@ -3489,13 +3489,28 @@ batch-byte-native-compile-for-bootstrap
> (defun native-compile-async (paths &optional recursively load)
> "Compile PATHS asynchronously.
> PATHS is one path or a list of paths to files or directories.
> -`comp-async-jobs-number' specifies the number of (commands) to
> -run simultaneously. If RECURSIVELY, recurse into subdirectories
> -of given directories.
> -LOAD can be nil t or 'late."
> +
> +If optional argument RECURSIVELY is non-nil, recurse into
> +subdirectories of given directories.
> +
> +If optional argument LOAD is non-nil, request to load the file
> +after compiling.
> +
> +The variable `comp-async-jobs-number' specifies the number
> +of (commands) to run simultaneously.
> +
> +LOAD can also be the symbol `late'. This is used internally if
> +the byte code has already been loaded when this function is
> +called. It means that we requests the special kind of load,
> +necessary in that situation, called \"late\" loading.
> +
> +During a \"late\" load instead of executing all top level forms
> +of the original files, only function definitions are
> +loaded (paying attention to have these effective only if the
> +bytecode definition was not changed in the meanwhile)."
> (comp-ensure-native-compiler)
> (unless (member load '(nil t late))
> - (error "LOAD must be nil t or 'late"))
> + (error "LOAD must be nil, t or 'late"))
> (unless (listp paths)
> (setf paths (list paths)))
> (let (files)
LGTM thanks for the nice clean-up
- bug#44676: [PATCH] Support native compilation of packages on install, (continued)
- bug#44676: [PATCH] Support native compilation of packages on install, Stefan Kangas, 2020/11/20
- bug#44676: [PATCH] Support native compilation of packages on install, Andrea Corallo, 2020/11/20
- bug#44676: [PATCH] Support native compilation of packages on install, Stefan Kangas, 2020/11/20
- bug#44676: [PATCH 4/4] Support native compilation of packages on install, Andrea Corallo, 2020/11/20
- bug#44676: [PATCH 4/4] Support native compilation of packages on install, Stefan Kangas, 2020/11/20
- bug#44676: [PATCH 4/4] Support native compilation of packages on install, Andrea Corallo, 2020/11/21
- bug#44676: [PATCH 1/4] Support native compilation of packages on install, Andrea Corallo, 2020/11/20
- bug#44676: [PATCH 2/4] Support native compilation of packages on install, Andrea Corallo, 2020/11/20
- bug#44676: [PATCH 2/4] Support native compilation of packages on install, Stefan Kangas, 2020/11/20
- bug#44676: [PATCH 2/4] Support native compilation of packages on install, Andrea Corallo, 2020/11/20
- bug#44676: [PATCH 3/4] Support native compilation of packages on install,
Andrea Corallo <=