[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#44270: 24.5; EMMS failures while installing
From: |
Stefan Kangas |
Subject: |
bug#44270: 24.5; EMMS failures while installing |
Date: |
Wed, 4 Nov 2020 23:25:26 -0800 |
Yoni Rabkin <yoni@rabkins.net> writes:
>> Indeed, I think EMMS should add a dependency on seq:
>>
>> ;; Package-Requires: ((cl-lib "0.5") (seq "2.22"))
>
> The code which requires seq (in emms-browser.el) was added in 2017
> (contemporaneous with Emacs 25.2), but of course Emacs 24.5 dates back
> from 2015.
>
> Should I add a dependency on a particular version of Emacs in the
> meantime?
I think it's better if you add a dependency on seq actually. The
package system should automatically install it on old versions, and the
GNU ELPA package has compatibility code that makes it work with Emacs
version 24.x.
> I'll see if it possible to re-write that code without seq and therefore
> to regain that backward compatibility.
Unless you want Emacs 23 compatibility, I don't think it is strictly
necessary to get rid of the seq dependency.