tags 14398 patch
quit
> 1. The `Revert...' menu items should be controled by either :enable or
> :visible. It makes no sense to show a user an active menu item `Undo
> Edits in Customization Buffer' if there have been no edits. After a
> user clicks this, undoing any edits, this menu item should disappear or
> be dimmed. Similarly for other menu items.
Now that widget-choose supports extended menus, this can be done like in
Bug#4787.
> 2. `Apply' is not helpful as is. The name does not sufficiently
> indicate what it does (apply what? to what?). The help echo is also not
> helpful enough: `Apply settings (for current session only)'. What
> settings?
While "Apply" might not be helpful, I think that the help-echo
answers the questions. And I'd say it is evident that it talks about
the settings the user is seeing in the Custom buffer at that moment.
> And again, if no settings have been changed (edited) then
> this button should not even be available. Its presence when it is a
> no-op just confuses.
Makes sense to me. And this can be easily controlled by activating and
deactivating the widgets.
I think that toolbar icons and menu bar items should also be
enabled/disabled according to the state of the options in the Custom
buffer, so I propose a patch that adds logic to do that as well.
0001-Enable-disable-buttons-tool-bar-and-menu-items-in-Cu.patch