bug#44384: 27.1; Bug in finder-commentary buffer

[Stefan Kangas]

tags 44384 fixed
close 44384 28.1
thanks

Stephen Berman <stephen.berman@gmx.net> writes:

> On Mon, 02 Nov 2020 04:13:35 +0000 Robert Thorpe 
> <rt@robertthorpeconsulting.com> wrote:
>
>> The quit feature in the finder-commentary buffer doesn't work.  I use
>> finder-commentary on a library, e.g. M-x finder-commentary appt.  Then I
>> switch to the buffer it creates.  Now, 'C-h m' tells me that I can press
>> "q" to quit it and all other finder buffers.  This doesn't work.  It
>> seems to be because the code is expecting the buffer name to be
>> different.
>
> This happens in both emacs-27 and master, but not in 26.3.  The
> difference is due to this change:

I have now fixed this on master.  The fix will be in Emacs 28.1.

>       (finder-exit): We don't use "*Finder-package*" and "*Finder
>       Category*" buffers anymore.
>
> Despite this commit message, finder.el still contains this code:
>
>   (defun finder-commentary (file)
>     "Display FILE's commentary section.
>   FILE should be in a form suitable for passing to `locate-library'."
>   [...]
>       (pop-to-buffer "*Finder-package*")

Indeed, it does seem like the removal of Finder-package was never really
completed.  Maybe someone should look this all over, for example by
giving `describe-package' all the capabilities of `finder-commentary'.