bug#43973: 28.0.50; [NS] Two crashes on macOS

[Robert Pluim]

>>>>> On Tue, 13 Oct 2020 21:33:42 +0100, Alan Third <alan@idiocy.org> said:

    Alan> On Tue, Oct 13, 2020 at 03:00:31PM +0200, Robert Pluim wrote:
    >> 
    >> (lldb) bt
    >> * thread #1, queue = 'com.apple.main-thread', stop reason = 
EXC_BAD_ACCESS (code=1, address=0x20)
    >> * frame #0: 0x00007fff6be26678 libobjc.A.dylib`objc_release + 24
    >> frame #1: 0x00000001001f5d1f emacs`-[EmacsImage 
dealloc](self=0x0000000102ac8ff0, _cmd=<unavailable>) at nsimage.m:286:3 [opt]
    Alan> <snip>
    >> 
    >> which is nsimage.m:
    >> 
    >> - (void)dealloc
    >> {
    >> [stippleMask release];
    >> [bmRep release];
    >> [transform release];  <====
    >> [super dealloc];
    >> }
    >> 
    >> Alan?

    Alan> Are you sure it's crashing on that line? That makes no sense as
    Alan> there's nowhere else that can release the transform, and if the image
    Alan> doesn't have a transform set it should be nil so releasing it would be
    Alan> a no-op... 

If I comment out [transform release]; I canʼt make it crash.

Robert
--