bug#43543: 28.0.50; Supress truncate notice in eldoc

[Lars Ingebrigtsen]

João Távora <joaotavora@gmail.com> writes:

> I fixed this in the latest commit to the scratch/eldoc-display-functions
> branch.  To do so, I much simplified the semantics of a numeric value
> given to eldoc-echo-area-use-multiline-p.  When I first idealized them
> around three months ago, I thought it should count screen lines -- not
> logical lines.  But now I changed my mind and switched to logical lines,
> for a number of reasons:
>
> - estimating screen lines is complicated (which probably led to the
>   aforementioned bug);
>
> - using screen lines overlaps in meaning with the existing variable
>   max-mini-window-height, which is honoured by the display engine;
>
> - I had at least one request by one user of Eglot (Andrii, in CC) to use
>   the "logical lines" behaviour. 
>
> We can always enhance the code later on to bring-back the screen lines
> behaviour (maybe controlled by a separate variable), in case anyone was
> already very fond of it.  Also keep in mind that setting the variable to
> `nil' already mandates a single screen line (a meaning which it has
> always had).
>
> Let me know what you think,
> João

Hm...  Logical lines is fine by me, but I wonder whether visual lines is
slightly more logical here?  This is for display purposes, after all.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no