[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#43381: 27.1.50; Maybe wrong cursor FG color in NS port
From: |
Lars Ingebrigtsen |
Subject: |
bug#43381: 27.1.50; Maybe wrong cursor FG color in NS port |
Date: |
Tue, 15 Sep 2020 14:22:20 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Eli Zaretskii <eliz@gnu.org> writes:
>> > Now you mention it, I can see that the X ports use the face colours as
>> > well...
>> >
>> > xterm.c:1518
>> > xgcv.background = s->f->output_data.x->cursor_pixel;
>> > xgcv.foreground = s->face->background;
>> > ^ ^
>>
>> Yeah, it looks like it's been like that since at least the 90s. So...
>> the documentation is just wrong?
>
> Yes, the documentation is inaccurate: it describes what happens when
> the text at point uses the default face. When the face is not the
> default, we merge that face into the cursor face, and that is what you
> see.
>
> We should fix the documentation.
Or should we fix the code? As the example demonstrates, this makes some
of the inverse-blinked text difficult to read. Presumably the colour
distance between the cursor and the default face's background is more
legible?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
- bug#43381: 27.1.50; Maybe wrong cursor FG color in NS port, Dale Sedivec, 2020/09/13
- bug#43381: 27.1.50; Maybe wrong cursor FG color in NS port, Lars Ingebrigtsen, 2020/09/13
- bug#43381: 27.1.50; Maybe wrong cursor FG color in NS port, Alan Third, 2020/09/13
- bug#43381: 27.1.50; Maybe wrong cursor FG color in NS port,
Lars Ingebrigtsen <=
- bug#43381: 27.1.50; Maybe wrong cursor FG color in NS port, Eli Zaretskii, 2020/09/15
- bug#43381: 27.1.50; Maybe wrong cursor FG color in NS port, Eli Zaretskii, 2020/09/15
- bug#43381: 27.1.50; Maybe wrong cursor FG color in NS port, Lars Ingebrigtsen, 2020/09/17
- bug#43381: 27.1.50; Maybe wrong cursor FG color in NS port, Eli Zaretskii, 2020/09/17
- bug#43381: 27.1.50; Maybe wrong cursor FG color in NS port, Lars Ingebrigtsen, 2020/09/17
- bug#43381: 27.1.50; Maybe wrong cursor FG color in NS port, Eli Zaretskii, 2020/09/17
- bug#43381: 27.1.50; Maybe wrong cursor FG color in NS port, Lars Ingebrigtsen, 2020/09/18
- bug#43381: 27.1.50; Maybe wrong cursor FG color in NS port, Eli Zaretskii, 2020/09/18
- bug#43381: 27.1.50; Maybe wrong cursor FG color in NS port, Lars Ingebrigtsen, 2020/09/18
- bug#43381: 27.1.50; Maybe wrong cursor FG color in NS port, Eli Zaretskii, 2020/09/18