[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#10483: [PATCH] cperl-mode: Avoid endless loop
From: |
Lars Ingebrigtsen |
Subject: |
bug#10483: [PATCH] cperl-mode: Avoid endless loop |
Date: |
Fri, 04 Sep 2020 05:17:45 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Harald Jörg <haj@posteo.de> writes:
> So be it: My attempt to do this is attached, together with tests
> to verify that my loop termination isn't harmful to the function.
Great; I've applied your fix (along with the test) to Emacs 28.
> As always, a review is welcome. I still haven't much experience
> in Elisp.
Looks good to me. The only detail is that we normally want the first
line of a doc string to be a complete sentence, and in one case it
wasn't:
+(ert-deftest cperl-mode-test-bug-10483 ()
+ "Verifies that a piece of code which ends in a paren without a
+statement terminato ron tne same line does not loop forever. The
But this is in the test harness, so I don't think we really have much of
a style convention going here, so I didn't fix that up before applying.
> I haven't found examples to steal from, and also missed the
> fork/waitpid stuff which I use for such tasks in Perl.
Yeah... Perhaps Emacs should grow some convenience functions for this
stuff?
Anyway, the patch fixes the reported bug here, so I'm closing this bug
report.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
- bug#10483: [PATCH] cperl-mode: Avoid endless loop, Harald Jörg, 2020/09/01
- bug#10483: [PATCH] cperl-mode: Avoid endless loop,
Lars Ingebrigtsen <=
- bug#10483: [PATCH] cperl-mode: Avoid endless loop, Eli Zaretskii, 2020/09/04
- bug#10483: [PATCH] cperl-mode: Avoid endless loop, Lars Ingebrigtsen, 2020/09/04
- bug#10483: [PATCH] cperl-mode: Avoid endless loop, Andreas Schwab, 2020/09/04
- bug#10483: [PATCH] cperl-mode: Avoid endless loop, Lars Ingebrigtsen, 2020/09/04
- bug#10483: [PATCH] cperl-mode: Avoid endless loop, Eli Zaretskii, 2020/09/04
- bug#10483: [PATCH] cperl-mode: Avoid endless loop, Lars Ingebrigtsen, 2020/09/04
- bug#10483: [PATCH] cperl-mode: Avoid endless loop, Andreas Schwab, 2020/09/04
- bug#10483: [PATCH] cperl-mode: Avoid endless loop, Eli Zaretskii, 2020/09/04
- bug#10483: [PATCH] cperl-mode: Avoid endless loop, Lars Ingebrigtsen, 2020/09/04
- bug#10483: [PATCH] cperl-mode: Avoid endless loop, Eli Zaretskii, 2020/09/04