[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wro
From: |
Lars Ingebrigtsen |
Subject: |
bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice |
Date: |
Fri, 04 Sep 2020 04:11:58 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Sean Whitton <spwhitton@spwhitton.name> writes:
> The docstring for that function says it exits from a require-match
> minibuffer. But completion gets used in other minibuffers too. So we
> need to clear the variable somewhere which gets called for every
> minibuffer exit.
Yeah, following the exit logic (from the multiple number of code paths)
isn't trivial here. But as far as I can tell, the exit-minibuffer
function is called in all the relevant code paths?
Does this fix the problem for you?
diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el
index 864726e3cc..8984440576 100644
--- a/lisp/minibuffer.el
+++ b/lisp/minibuffer.el
@@ -2062,6 +2062,9 @@ exit-minibuffer
;; (or to turn it into a list of buffers, ...), but in the mean time,
;; this should do the trick in most cases.
(setq deactivate-mark nil)
+ ;; Clear any computed default values (so that they're not used on
+ ;; the next invocation).
+ (setq completion-content-when-empty nil)
(throw 'exit nil))
(defun self-insert-and-exit ()
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
- bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice, Lars Ingebrigtsen, 2020/09/01
- bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice, Sean Whitton, 2020/09/03
- bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice,
Lars Ingebrigtsen <=
- bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice, Sean Whitton, 2020/09/03
- bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice, Lars Ingebrigtsen, 2020/09/03
- bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice, Sean Whitton, 2020/09/04
- bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice, Lars Ingebrigtsen, 2020/09/05
- bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice, Sean Whitton, 2020/09/05
- bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice, Lars Ingebrigtsen, 2020/09/05
- bug#19032: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice, João Távora, 2020/09/06
- bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice, Lars Ingebrigtsen, 2020/09/07
- bug#19032: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice, João Távora, 2020/09/07
- bug#19032: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice, Lars Ingebrigtsen, 2020/09/07