[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#12443: 24.2.50; Default values in the minibuffer prompt (fix inconsi
From: |
Lars Ingebrigtsen |
Subject: |
bug#12443: 24.2.50; Default values in the minibuffer prompt (fix inconsisntecy) |
Date: |
Fri, 28 Aug 2020 16:11:03 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Juri Linkov <juri@jurta.org> writes:
> Maybe the final separator (colon) should be customizable as well.
> What if someone wants to use the same character as used in shell, i.e. '$'.
> Then moving the currently hard-coded colon to the default value
> " (default %s): " will allow the users to customize it to
> " (default %s)$ "
Good idea. I'll adjust the variable and the code.
> Shouldn't one of these calls (namely 'describe-function') be further
> simplified with
>
> diff --git a/lisp/help-fns.el b/lisp/help-fns.el
> index d302c05283..617f6ae5e8 100644
> --- a/lisp/help-fns.el
> +++ b/lisp/help-fns.el
> @@ -151,9 +151,7 @@ describe-function
> (let* ((fn (function-called-at-point))
> (enable-recursive-minibuffers t)
> (val (completing-read
> - (if fn
> - (format-prompt "Describe function" fn)
> - "Describe function: ")
> + (format-prompt "Describe function" fn)
> #'help--symbol-completion-table
> (lambda (f) (or (fboundp f) (get f 'function-documentation)))
> t nil nil
>
> But something is still wrong - with the nil default value the prompt becomes:
>
> "Describe function (default nil): "
>
> whereas it should be
>
> "Describe function: "
Yes, that's why you can't use format-prompt when there's no default value.
> It seems 'format-prompt' should not use 'minibuffer-default-prompt-format'
> when 'default' is nil.
nil is a perfectly valid default value in many prompts.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
- bug#12443: 24.2.50; Default values in the minibuffer prompt (fix inconsisntecy), (continued)
- bug#12443: 24.2.50; Default values in the minibuffer prompt (fix inconsisntecy), Stefan Kangas, 2020/08/25
- bug#12443: 24.2.50; Default values in the minibuffer prompt (fix inconsisntecy), Stefan Monnier, 2020/08/25
- bug#12443: 24.2.50; Default values in the minibuffer prompt (fix inconsisntecy), Lars Ingebrigtsen, 2020/08/25
- bug#12443: 24.2.50; Default values in the minibuffer prompt (fix inconsisntecy), Drew Adams, 2020/08/25
- bug#12443: 24.2.50; Default values in the minibuffer prompt (fix inconsisntecy), Stefan Kangas, 2020/08/25
- bug#12443: 24.2.50; Default values in the minibuffer prompt (fix inconsisntecy), Juri Linkov, 2020/08/25
- bug#12443: 24.2.50; Default values in the minibuffer prompt (fix inconsisntecy), Lars Ingebrigtsen, 2020/08/25
- bug#12443: 24.2.50; Default values in the minibuffer prompt (fix inconsisntecy), Stefan Monnier, 2020/08/25
- bug#12443: 24.2.50; Default values in the minibuffer prompt (fix inconsisntecy), Lars Ingebrigtsen, 2020/08/26
- bug#12443: 24.2.50; Default values in the minibuffer prompt (fix inconsisntecy), Juri Linkov, 2020/08/27
- bug#12443: 24.2.50; Default values in the minibuffer prompt (fix inconsisntecy),
Lars Ingebrigtsen <=
- bug#12443: 24.2.50; Default values in the minibuffer prompt (fix inconsisntecy), Stefan Monnier, 2020/08/28
- bug#12443: 24.2.50; Default values in the minibuffer prompt (fix inconsisntecy), Lars Ingebrigtsen, 2020/08/30
- bug#12443: 24.2.50; Default values in the minibuffer prompt (fix inconsisntecy), Lars Ingebrigtsen, 2020/08/28