bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#16542: 24.3.50; When finding a file via a bookmark, that file is not


From: Lars Ingebrigtsen
Subject: bug#16542: 24.3.50; When finding a file via a bookmark, that file is not part of file-name-history
Date: Tue, 25 Aug 2020 12:57:03 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

Bastien Guerry <bzg@altern.org> writes:

> The subject line says it all.
>
> This trivial patch fixes it.
>
> Comments welcome,
>
> diff --git a/lisp/bookmark.el b/lisp/bookmark.el
> index 5307cad..52697c2 100644
> --- a/lisp/bookmark.el
> +++ b/lisp/bookmark.el

[...]

> +       (add-to-history 'file-name-history file)

I think this would be very surprising -- finding other things in the
minibuffer history than things I've typed in would be pretty odd.

As suggested, having a separate list of all visited files would be nice,
but the UX here would be pretty awkward.  That's discussed in bug#12915,
though, so I'm closing this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





reply via email to

[Prev in Thread] Current Thread [Next in Thread]