bug#24581: 25.1 crash in ns_scroll_run after closing a frame

[Alan Third]

On Thu, Aug 13, 2020 at 04:51:35PM -0400, Win Treese wrote:
> 
> 
> > On Aug 13, 2020, at 2:46 PM, Alan Third <alan@idiocy.org> wrote:
> > 
> > Hi Win,
> > 
> > What version of Emacs is Aquamacs based on? Is it still Emacs 25?
> 
> Hi, Alan. 
> 
> Yes. The current version of Aquamacs (3.5) is based on Emacs 25.3.50.1.

Hmm, that's pretty damn old. I don't think GNU Emacs 25 even builds on
recent macOS versions. There have been a LOT of crash fixes made to
the NS code since then, although I imagine a few have been back-ported
to Aquamacs.

I suspect the best option may be just to check whether the frame is
still live at the top of ns_scroll_run and return if not. Assuming it
doesn't do that already, of course.

> My current plan (if you’re interested ) is to try fixing several of the
> known bugs that are getting in people’s way, ship that as 3.6, and then
> roll the code base forward to catch up with the current Emacs release.
> 
> I’ll probably do that by merging onto the earlier releases so that it’s
> easier to understand the changes at each point, and along the way I
> hope to decrease the amount of Aquamacs-specific code where we can.

You'll probably run into the fun diversion the GUI code took in Emacs
26.something and Emacs 27 which has (mostly) been reverted for Emacs
28. But thinking about it, you must have code in Aquamacs to get round
the same issue, so perhaps you're already in the midst of it (or have
a better solution).
-- 
Alan Third