[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#36597: 27.0.50; rehash hash tables eagerly in pdumper
From: |
Andy Moreton |
Subject: |
bug#36597: 27.0.50; rehash hash tables eagerly in pdumper |
Date: |
Tue, 11 Aug 2020 19:27:00 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (windows-nt) |
On Tue 11 Aug 2020, Paul Eggert wrote:
> On 8/11/20 10:00 AM, Eli Zaretskii wrote:
>>> I suggest going back to Fmake_vector (h->hash, Qnil), as in the
>>> attached patch. It's shorter, and it actually compiles.
>> Yes, I did that, thanks.
>
> The compilation issue was due to pdumper enabling -Wconversion, which causes
> more trouble than it cures (but that is a different topic). I worked around
> the glitch by installing the attached further patch, which should also help
> explain the motivation for make_nil_vector.
Eli's fixes have addressed issues with the MinGW toolchains, but Mingw64
64bit builds are still broken:
C:/emacs/git/emacs/master/src/pdumper.c: In function 'dump_read_all':
C:/emacs/git/emacs/master/src/pdumper.c:5078:60: error: conversion from
'size_t' {aka 'long long unsigned int'} to 'unsigned int' may change value
[-Werror=conversion]
5078 | ssize_t chunk = read (fd, (char *) buf + bytes_read,
chunk_to_read);
| ^~~~~~~~~~~~~
- bug#36597: 27.0.50; rehash hash tables eagerly in pdumper, (continued)
- bug#36597: 27.0.50; rehash hash tables eagerly in pdumper, Eli Zaretskii, 2020/08/11
- bug#36597: 27.0.50; rehash hash tables eagerly in pdumper, Paul Eggert, 2020/08/11
- bug#36597: 27.0.50; rehash hash tables eagerly in pdumper, Eli Zaretskii, 2020/08/12
- bug#36597: 27.0.50; rehash hash tables eagerly in pdumper, Eli Zaretskii, 2020/08/12
- bug#36597: 27.0.50; rehash hash tables eagerly in pdumper, Paul Eggert, 2020/08/12
- bug#36597: 27.0.50; rehash hash tables eagerly in pdumper, Eli Zaretskii, 2020/08/12
- bug#36597: 27.0.50; rehash hash tables eagerly in pdumper, Andy Moreton, 2020/08/12
- bug#36597: 27.0.50; rehash hash tables eagerly in pdumper, Pip Cet, 2020/08/11
- bug#36597: 27.0.50; rehash hash tables eagerly in pdumper, Eli Zaretskii, 2020/08/11
- bug#36597: 27.0.50; rehash hash tables eagerly in pdumper, Paul Eggert, 2020/08/11
- bug#36597: 27.0.50; rehash hash tables eagerly in pdumper,
Andy Moreton <=
- bug#36597: 27.0.50; rehash hash tables eagerly in pdumper, Eli Zaretskii, 2020/08/11