[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#41977: 28.0.50; [PATCH]: eval-when-compile eshell in project.el
|
From: |
Basil L. Contovounesios |
|
Subject: |
bug#41977: 28.0.50; [PATCH]: eval-when-compile eshell in project.el |
|
Date: |
Sun, 21 Jun 2020 18:55:34 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Theodor Thornhill <theo@thornhill.no> writes:
> "Basil L. Contovounesios" <contovob@tcd.ie> writes:
>
>> Since eshell-buffer-name is a variable, eval-when-compile is not the
>> right thing to do here. Instead, there should be a
>> (defvar eshell-buffer-name) inside project-eshell declaring the symbol
>> as special. Right?
>
> You are absolutely correct, and TIL - thanks :)
>
> Below is another patch doing this. Works fine in emacs -Q
Thanks, LGTM.
--
Basil