|
From: | Dmitry Gutov |
Subject: | bug#40919: 27.0.91; next-error-select-buffer does not always behave as documented |
Date: | Tue, 26 May 2020 19:20:50 +0300 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 |
On 26.05.2020 19:06, Eli Zaretskii wrote:
Cc: juri@linkov.net, 40919@debbugs.gnu.org, tspiteri@ieee.org From: Dmitry Gutov <dgutov@yandex.ru> Date: Tue, 26 May 2020 02:17:34 +0300 The attached patch moves case #2 into a new function and makes it the default value of the said defcustom (thus case #2 effectively moves into case #1). As a result, the default behavior doesn't change, but the user will have a much easier time turning off case #2.Maybe I don't understand something, but it looks to me that this changes the behavior if next-error-find-buffer-function has a non-default value:
Yes. I only claimed that the _default_ behavior doesn't change. The user option was only added in Emacs 27, so this doesn't seem to be a big problem.
previously what's now next-error-no-navigation-try-current would be executed after calling next-error-find-buffer-function, now it isn't. Is that really necessary?
It seems to be the best and safest option at the moment. I imagine that if someone customized the variable they either used the only available non-#'ignore value and thus want the Emacs 26 behavior (so taking out case #2 would only make them happier), or wrong their own function, in which case they might need to update that function.
(Btw, the textual descriptions of the options both in the patch and those already in the code are confusingly obscure, so much so that I don't think I could understand what each one does.)Knowing the subject matter somewhat, I think the descriptions are meaningful enough, but to make sense of them one has to understand how the whole feature comes together. E.g. at what times next-error-find-buffer is called.I think I know something about the subject matter, and still the text is quite impenetrable for me.
Perhaps they could be improved. Still, the situation is probably better than it was before.
Do the 'next-error' entries in NEWS.27 make sense to you, BTW?
All in all, I feel (for quite some time) that this area is over-engineered and keeps bumping into more and more unintended consequences. Maybe it's time to take a step back and rethink the entire subject? (But definitely not on the release branch.)That's what we're doing here.Sigh.
Also see the related discussion in emacs-devel (one that stems from 2018).
[Prev in Thread] | Current Thread | [Next in Thread] |