[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#41239: GTK builds crashing in XTread_socket after deleting a frame
From: |
Noam Postavsky |
Subject: |
bug#41239: GTK builds crashing in XTread_socket after deleting a frame |
Date: |
Thu, 21 May 2020 21:23:49 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.91 (gnu/linux) |
Eli Zaretskii <eliz@gnu.org> writes:
> Can someone spot where we pass some wrong parameters to GTK/GIO
> functions in xg_prepare_tooltip? Or something we do wrong in
> xg_free_frame_widgets?
The patch below seems to fix it.
--- i/src/gtkutil.c
+++ w/src/gtkutil.c
@@ -1404,10 +1404,15 @@ xg_free_frame_widgets (struct frame *f)
FRAME_X_WINDOW (f) = 0; /* Set to avoid XDestroyWindow in xterm.c */
FRAME_X_RAW_DRAWABLE (f) = 0;
FRAME_GTK_OUTER_WIDGET (f) = 0;
+ if (x->ttip_widget)
+ {
+ /* Remove ttip_lbl from ttip_widget's custom slot before
+ destroying it, to avoid double-free (Bug#41239). */
+ gtk_tooltip_set_custom (x->ttip_widget, NULL);
+ g_object_unref (G_OBJECT (x->ttip_widget));
+ }
if (x->ttip_lbl)
gtk_widget_destroy (x->ttip_lbl);
- if (x->ttip_widget)
- g_object_unref (G_OBJECT (x->ttip_widget));
}
}
- bug#41239: GTK builds crashing in XTread_socket after deleting a frame, martin rudalics, 2020/05/13
- bug#41239: GTK builds crashing in XTread_socket after deleting a frame, Eli Zaretskii, 2020/05/13
- bug#41239: GTK builds crashing in XTread_socket after deleting a frame, martin rudalics, 2020/05/14
- bug#41239: GTK builds crashing in XTread_socket after deleting a frame, Eli Zaretskii, 2020/05/14
- bug#41239: GTK builds crashing in XTread_socket after deleting a frame, martin rudalics, 2020/05/15
- bug#41239: GTK builds crashing in XTread_socket after deleting a frame, Eli Zaretskii, 2020/05/15
- bug#41239: GTK builds crashing in XTread_socket after deleting a frame, martin rudalics, 2020/05/16
- bug#41239: GTK builds crashing in XTread_socket after deleting a frame, Noam Postavsky, 2020/05/19
- bug#41239: GTK builds crashing in XTread_socket after deleting a frame, martin rudalics, 2020/05/20
- bug#41239: GTK builds crashing in XTread_socket after deleting a frame, Eli Zaretskii, 2020/05/20
- bug#41239: GTK builds crashing in XTread_socket after deleting a frame,
Noam Postavsky <=
- bug#41239: GTK builds crashing in XTread_socket after deleting a frame, martin rudalics, 2020/05/22
- bug#41239: GTK builds crashing in XTread_socket after deleting a frame, Eli Zaretskii, 2020/05/22
- bug#41239: GTK builds crashing in XTread_socket after deleting a frame, Noam Postavsky, 2020/05/22
- bug#41239: GTK builds crashing in XTread_socket after deleting a frame, Eli Zaretskii, 2020/05/22
- bug#41239: GTK builds crashing in XTread_socket after deleting a frame, Noam Postavsky, 2020/05/22
- bug#41239: GTK builds crashing in XTread_socket after deleting a frame, Eli Zaretskii, 2020/05/22
- bug#41239: GTK builds crashing in XTread_socket after deleting a frame, Noam Postavsky, 2020/05/24
- bug#41239: GTK builds crashing in XTread_socket after deleting a frame, martin rudalics, 2020/05/22
- bug#41239: GTK builds crashing in XTread_socket after deleting a frame, Noam Postavsky, 2020/05/22
- bug#41239: GTK builds crashing in XTread_socket after deleting a frame, Eli Zaretskii, 2020/05/23