[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#29533: Fwd: [Feature Request] ERC: let erc-join-channel support to s
From: |
stardiviner |
Subject: |
bug#29533: Fwd: [Feature Request] ERC: let erc-join-channel support to select channels from history or a defined list |
Date: |
Mon, 18 May 2020 20:21:10 +0800 |
User-agent: |
mu4e 1.4; emacs 28.0.50 |
Stefan Kangas <stefan@marxist.se> writes:
> stardiviner <numbchild@gmail.com> writes:
>
>> + (mapcar 'car erc-join-channels-alist))
>> lisp/erc/erc.el:4048: indent with spaces.
>> + erc-join-channels-alist)))))
>> ```
>>
>> I didi an google search, but still don't know how to set this. Shouldn't it
>> be
>> space-indented?
>
> Yes, you should prefer indenting with spaces for the most part.
I figured why, I'm using Magit, and it seems enabled verify hooks by default.
>
> Maybe there is something in your local git configuration that is causing
> this?
>
>> And here is my patch diff. How should I submit this patch to Emacs/erc ?
>
> You should ideally send the patch as an attached file produced by:
>
> git format-patch -1 HEAD
>
> Also, we have some requirements for contributions, such as including a
> ChangeLog entry. This is described in the CONTRIBUTE file, and you can
> also see examples in the git log. (You can use `C-x 4 a' so you don't
> have to type as much.)
>
> Are there any changes that needs doing in the manual? Should this be
> announced in etc/NEWS?
No need to be announced in etc/NEWS. It's still original keybinding. And not a
big difference.
At last, I attached my generated commit in attachment.
--
[ stardiviner ]
I try to make every word tell the meaning that I want to express.
Blog: https://stardiviner.github.io/
IRC(freenode): stardiviner, Matrix: stardiviner
GPG: F09F650D7D674819892591401B5DF1C95AE89AC3
0001-Join-channel-smartly-from-alist-of-stored-channels.patch
Description: Text Data
signature.asc
Description: PGP signature
- bug#29533: Fwd: [Feature Request] ERC: let erc-join-channel support to select channels from history or a defined list, Stefan Kangas, 2020/05/04
- bug#29533: Fwd: [Feature Request] ERC: let erc-join-channel support to select channels from history or a defined list, stardiviner, 2020/05/04
- bug#29533: Fwd: [Feature Request] ERC: let erc-join-channel support to select channels from history or a defined list, Stefan Kangas, 2020/05/04
- bug#29533: Fwd: [Feature Request] ERC: let erc-join-channel support to select channels from history or a defined list, stardiviner, 2020/05/12
- bug#29533: Fwd: [Feature Request] ERC: let erc-join-channel support to select channels from history or a defined list, Stefan Kangas, 2020/05/12
- bug#29533: Fwd: [Feature Request] ERC: let erc-join-channel support to select channels from history or a defined list, stardiviner, 2020/05/13
- bug#29533: Fwd: [Feature Request] ERC: let erc-join-channel support to select channels from history or a defined list, stardiviner, 2020/05/13
- bug#29533: Fwd: [Feature Request] ERC: let erc-join-channel support to select channels from history or a defined list, Stefan Kangas, 2020/05/13
- bug#29533: Fwd: [Feature Request] ERC: let erc-join-channel support to select channels from history or a defined list, stardiviner, 2020/05/13
- bug#29533: Fwd: [Feature Request] ERC: let erc-join-channel support to select channels from history or a defined list, Stefan Kangas, 2020/05/14
- bug#29533: Fwd: [Feature Request] ERC: let erc-join-channel support to select channels from history or a defined list,
stardiviner <=
- bug#29533: Fwd: [Feature Request] ERC: let erc-join-channel support to select channels from history or a defined list, Stefan Kangas, 2020/05/18
- bug#29533: Fwd: [Feature Request] ERC: let erc-join-channel support to select channels from history or a defined list, Noam Postavsky, 2020/05/13
- bug#29533: Fwd: [Feature Request] ERC: let erc-join-channel support to select channels from history or a defined list, stardiviner, 2020/05/13