[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#40573: 27.0.90; flymake-mode broken in scratch buffer
From: |
Eli Zaretskii |
Subject: |
bug#40573: 27.0.90; flymake-mode broken in scratch buffer |
Date: |
Sun, 19 Apr 2020 17:01:03 +0300 |
> From: João Távora <joaotavora@gmail.com>
> Date: Sun, 19 Apr 2020 00:36:36 +0100
> Cc: "Basil L. Contovounesios" <contovob@tcd.ie>, Stefan Monnier
> <monnier@iro.umontreal.ca>,
> Juri Linkov <juri@linkov.net>, 40573@debbugs.gnu.org, Dmitry Gutov
> <dgutov@yandex.ru>
>
> Here's the final patch as a sum of all the commits in the
> scratch/add-lisp-data-mode
> branch. I fixed the small lisp-mode-variables backward incompatibility
> issue.
Thanks for working on this.
> Any comments/objections?
I have one comment and one objection, below.
> Does this need documentation?
The new mode should be called out in NEWS, yes.
> diff --git a/lisp/emacs-lisp/lisp-mode.el b/lisp/emacs-lisp/lisp-mode.el
> index 13263f2fb5..3b0f5493ee 100644
> --- b/lisp/emacs-lisp/lisp-mode.el
> +++ a/lisp/emacs-lisp/lisp-mode.el
> @@ -611,15 +611,10 @@
> ;; a single docstring. Let's fix it here.
> (if (looking-at "\\s-+\"[^\n\"]+\"\\s-*$") ""))
>
> -(defun lisp-mode-variables (&optional lisp-syntax keywords-case-insensitive
> - elisp)
> +(defun lisp-mode-variables (&rest ignored)
Please don't make this backward-incompatible change. Let's keep the
API of this function unchanged.
- bug#40573: 27.0.90; flymake-mode broken in scratch buffer, (continued)
- bug#40573: 27.0.90; flymake-mode broken in scratch buffer, João Távora, 2020/04/18
- bug#40573: 27.0.90; flymake-mode broken in scratch buffer, Eli Zaretskii, 2020/04/18
- bug#40573: 27.0.90; flymake-mode broken in scratch buffer, João Távora, 2020/04/18
- bug#40573: 27.0.90; flymake-mode broken in scratch buffer, João Távora, 2020/04/18
- bug#40573: 27.0.90; flymake-mode broken in scratch buffer, Dmitry Gutov, 2020/04/18
- bug#40573: 27.0.90; flymake-mode broken in scratch buffer, João Távora, 2020/04/19
- bug#40573: 27.0.90; flymake-mode broken in scratch buffer, Dmitry Gutov, 2020/04/19
- bug#40573: 27.0.90; flymake-mode broken in scratch buffer, João Távora, 2020/04/19
- bug#40573: 27.0.90; flymake-mode broken in scratch buffer, Dmitry Gutov, 2020/04/19
- bug#40573: 27.0.90; flymake-mode broken in scratch buffer, Stefan Monnier, 2020/04/18
- bug#40573: 27.0.90; flymake-mode broken in scratch buffer,
Eli Zaretskii <=
- bug#40573: 27.0.90; flymake-mode broken in scratch buffer, João Távora, 2020/04/19
- bug#40573: 27.0.90; flymake-mode broken in scratch buffer, Eli Zaretskii, 2020/04/20
- bug#40573: 27.0.90; flymake-mode broken in scratch buffer, João Távora, 2020/04/20
- bug#40573: 27.0.90; flymake-mode broken in scratch buffer, Eli Zaretskii, 2020/04/20
- bug#40573: 27.0.90; flymake-mode broken in scratch buffer, Basil L. Contovounesios, 2020/04/18
- bug#40573: 27.0.90; flymake-mode broken in scratch buffer, João Távora, 2020/04/18
- bug#40573: 27.0.90; flymake-mode broken in scratch buffer, Basil L. Contovounesios, 2020/04/18
- bug#40573: 27.0.90; flymake-mode broken in scratch buffer, João Távora, 2020/04/19
- bug#40573: 27.0.90; flymake-mode broken in scratch buffer, Juri Linkov, 2020/04/18
- bug#40573: 27.0.90; flymake-mode broken in scratch buffer, João Távora, 2020/04/19