[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#40407: [PATCH] slow ENCODE_FILE and DECODE_FILE
From: |
Mattias Engdegård |
Subject: |
bug#40407: [PATCH] slow ENCODE_FILE and DECODE_FILE |
Date: |
Sat, 4 Apr 2020 18:41:39 +0200 |
4 apr. 2020 kl. 11.26 skrev Eli Zaretskii <eliz@gnu.org>:
> DECODE_FILE is called because the file name in question starts with a
> "~"? Otherwise, I don't think I understand why would expand-file-name
> need to decode a file name.
Maybe it's because default-directory started with a tilde. It doesn't really
matter; it's a common case, and the profiler tells us as much.
> IME, the cases where we can safely assume it's OK to return the same
> string are actually very rare. It is no accident that you saw so few
> calls of these functions where we use that optional behavior.
This does not mean that the remaining 179 calls require a copy; they just use
the default value of the parameter.
> Neither, IMO. Again, it's a separate problem, and let's keep our
> sights squarely on the original issue you wanted to fix. Let's tackle
> the NOCOPY issue in a separate discussion, OK?
Thank you, a separate bug for it is fine.
Here is a revised patch which takes the nocopy parameter into account (in its
inverted sense). Obviously it needs to be adapted if the nocopy inversion is
dealt with first; the two bugs do not commute.
0001-Avoid-expensive-recoding-for-ASCII-identity-cases-bu.patch
Description: Binary data
- bug#40407: [PATCH] slow ENCODE_FILE and DECODE_FILE, Mattias Engdegård, 2020/04/03
- bug#40407: [PATCH] slow ENCODE_FILE and DECODE_FILE, Eli Zaretskii, 2020/04/03
- bug#40407: [PATCH] slow ENCODE_FILE and DECODE_FILE, Mattias Engdegård, 2020/04/03
- bug#40407: [PATCH] slow ENCODE_FILE and DECODE_FILE, Eli Zaretskii, 2020/04/04
- bug#40407: [PATCH] slow ENCODE_FILE and DECODE_FILE,
Mattias Engdegård <=
- bug#40407: [PATCH] slow ENCODE_FILE and DECODE_FILE, Eli Zaretskii, 2020/04/04
- bug#40407: [PATCH] slow ENCODE_FILE and DECODE_FILE, Eli Zaretskii, 2020/04/04
- bug#40407: [PATCH] slow ENCODE_FILE and DECODE_FILE, Mattias Engdegård, 2020/04/04
- bug#40407: [PATCH] slow ENCODE_FILE and DECODE_FILE, Eli Zaretskii, 2020/04/04
- bug#40407: [PATCH] slow ENCODE_FILE and DECODE_FILE, Eli Zaretskii, 2020/04/04
- bug#40407: [PATCH] slow ENCODE_FILE and DECODE_FILE, Mattias Engdegård, 2020/04/05
- bug#40407: [PATCH] slow ENCODE_FILE and DECODE_FILE, Eli Zaretskii, 2020/04/05
- bug#40407: [PATCH] slow ENCODE_FILE and DECODE_FILE, Mattias Engdegård, 2020/04/05
- bug#40407: [PATCH] slow ENCODE_FILE and DECODE_FILE, Eli Zaretskii, 2020/04/04
- bug#40407: [PATCH] slow ENCODE_FILE and DECODE_FILE, Mattias Engdegård, 2020/04/04