bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#39662: 28.0.50; Emacs crashes in x_cr_define_fringe_bitmap if (fring


From: Robert Pluim
Subject: bug#39662: 28.0.50; Emacs crashes in x_cr_define_fringe_bitmap if (fringe-mode 0)
Date: Tue, 18 Feb 2020 21:03:58 +0100

>>>>> On Tue, 18 Feb 2020 21:50:27 +0200, Eli Zaretskii <eliz@gnu.org> said:

    >> From: Robert Pluim <rpluim@gmail.com>
    >> Date: Tue, 18 Feb 2020 20:32:37 +0100
    >> Cc: 39662@debbugs.gnu.org, Dmitry Gutov <dgutov@yandex.ru>
    >> 
    >> I took another look, signaling is not necessary, we can just make
    >> define-fringe-bitmap set the width to 1 or some other reasonable value
    >> if zero is passed in.

    Eli> The documentation says that WIDTH must be between 1 and 16, so I think
    Eli> signaling an error is OK.

But itʼs friendlier to existing code to change 0 to 1, no? Plus Iʼm
sure diff-hl is not the only package around using fringe bitmaps.

Robert





reply via email to

[Prev in Thread] Current Thread [Next in Thread]