[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#39452: [PATCH] vc-git-state fails for filenames with wildcards

From: Dmitry Gutov
Subject: bug#39452: [PATCH] vc-git-state fails for filenames with wildcards
Date: Fri, 14 Feb 2020 16:40:04 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0

On 14.02.2020 16:14, Eli Zaretskii wrote:
Any command that prompts for a file name, I guess.  vc-delete-file and
vc-rename-file come to mind.

In both of these commands entering a non-trivial pathspec is both undocumented and hard to do: look at the interactive form, it calls read-file-name with MUSTMATCH t. In other words, it doesn't let you input interactively anything that's not an existing file name.

But my comment was more general: we don't plan on not supporting Git
specs in file names, do we?

I don't see how we'd keep supporting them in these two particular commands without keeping bugs similar to this one unfixed (e.g. 'M-x vc-delete-file test[56].xx' where test[56].xx is an existing filename).

AFAICS, they're working purely by accident. That's not to say we can't introduce new versions of these commands that would accept pathspecs (or do it with C-u, etc).

reply via email to

[Prev in Thread] Current Thread [Next in Thread]