bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#37182: Acknowledgement (24.5; 24.5.1: C-u vc-dir-mark-all-files shou


From: Eli Zaretskii
Subject: bug#37182: Acknowledgement (24.5; 24.5.1: C-u vc-dir-mark-all-files should not mark directories)
Date: Wed, 05 Feb 2020 16:24:44 +0200

> From: Dmitry Gutov <address@hidden>
> Date: Wed, 5 Feb 2020 03:28:24 +0300
> 
> On 27.08.2019 2:06, Wolfgang Scherer wrote:
> >     (ewoc-map
> >      (lambda (filearg)
> > -      (unless (vc-dir-fileinfo->marked filearg)
> > +      (unless (or (vc-dir-fileinfo->directory filearg)
> > +                  (vc-dir-fileinfo->marked filearg))
> >          (setf (vc-dir-fileinfo->marked filearg) t)
> >          t))
> >      vc-ewoc))
> 
> LGTM (works, too).
> 
> Eli, this okay for emacs-27?

Yes, but please also fix the doc string to clearly say what happens
with directories.

Thanks.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]