bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep


From: Dmitry Gutov
Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep
Date: Fri, 24 Jan 2020 01:07:15 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0

On 23.01.2020 19:28, Stefan Monnier wrote:
We could introduce a new `minibuffer-require-match` variable (and mark
`minibuffer-completion-confirm` obsolete).

Why don't we just co-opt the older variable. A rename can come later. See patch 1.

Here's another issue related to the previous proposed fix: why *would* M-j exit minibuffer in all cases? It currently doesn't honor REQUIRE-MATCH=t (or the confirm- values, but I don't care about that). The default completing-read, as well as icomplete-mode, both honor it. The patch 2 fixes that.

Please take a look, y'all.

Attachment: 0001-Honor-require-match-nil-in-icomplete-fido-ret.patch
Description: Text Data

Attachment: 0002-Make-M-j-in-fido-mode-honor-REQUIRE-MATCH-t.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]