[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#36526: 26.2; Open diff at current location (feature request with sug
bug#36526: 26.2; Open diff at current location (feature request with suggested code)
Thu, 16 Jan 2020 01:50:34 +0300
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0
On 15.01.2020 5:20, Stefan Kangas wrote:
I've watched your video, and I think it looks interesting. I would
think it useful enough to include, and it certainly helps that you are
willing to do the work to get it done.
Unfortunately, I'm not a heavy vc user, so I don't feel fully
qualified to comment on this use case.
Could someone else please take a look at this proposal and give
Campbell a more informed reply?
Speaking of the "open diff at point" feature, it's very reminiscent of
the feature in a package of mine:
And the implementation is much shorter there. So far, I don't understand
I would be happy to facilitate moving this feature to the core, but for
obvious reasons (chiefly ease of review) I'd prefer to to be based off
my own code. Or to see a good explanation why it's not a good choice.
If the implementation in the package above doesn't cut it for some
reasons, similarly I'd prefer to see a patch against that code rather
than a full reimplementation. If feasible, of course.