[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#38749: 27.0.50; objc-mode: wrong imenu item

From: Alan Mackenzie
Subject: bug#38749: 27.0.50; objc-mode: wrong imenu item
Date: Mon, 6 Jan 2020 18:07:57 +0000
User-agent: Mutt/1.10.1 (2018-07-13)

Hello, HaiJun.

On Thu, Dec 26, 2019 at 18:31:55 +0800, HaiJun Zhang wrote:
> In GNU Emacs 27.0.50 (build 1, x86_64-apple-darwin17.7.0, NS appkit-1561.61 
> Version 10.13.6 (Build 17G10021))
>  of 2019-12-23 built on jundeMac
> Repository revision: 3ee8ee8476fef2a5e8159f7597e36e0953295ce2
> Repository branch: mod
> Windowing system distributor ‘Apple', version 10.3.1561
> System Description: Mac OS X 10.13.6

> Open file nsfns.m in emacs source(src/nsfns.m). Many imenu items are invalid.
> For example, “C/Copyright” and some more are in the header comment.

I've just spent some time fixing a more serious bug in the Objective-C
imenu mechanism.  This only occurs when I invoke imenu through the
keyboard (e.g. with M-x imenu), which might explain why it's survived so
long without detection.  If I invoke imenu with a mouse click, it works.

Anyhow, with nsfns.m, do M-x imenu <tab> C <tab> and select any item.
This works.  Now do M-x imenu.  This throws the error "Wrong type
argument: stringp, nil".

I've fixed this now, but haven't committed the fix yet.

Back to your bug - clearly what is happening is that the regular
expression search for functions is finding things in comments (such as
"Copyright (C)") which look like functions but aren't.  This is easy
enough to fix, by checking for comments and strings, but comes with a
fairly stiff time penalty.  On my 2½ year old Ryzen machine, scanning
the freshly visited Objc buffer currently takes 0.0196s.  With the check
for comments/strings, it takes 0.0650s.

That's a factor of ~3.25 slower.  On a slower machine (factor 3) with a
larger file (factor 3) this could mean the scanning would take 0.6s
rather than 0.2s.  This might be slow enough to annoy somebody a little.

Getting spurious entries in the index, like "Copyright" also is clearly
annoying, otherwise you wouldn't have submitted the bug report.  So
please give me a little time to decide which annoyance is the more
important.  Sorry!

Alan Mackenzie (Nuremberg, Germany).

reply via email to

[Prev in Thread] Current Thread [Next in Thread]