bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#30373: [PATCH] Implement finalizers for module functions (Bug#30373)


From: Pip Cet
Subject: bug#30373: [PATCH] Implement finalizers for module functions (Bug#30373)
Date: Fri, 3 Jan 2020 20:49:35 +0000

On Fri, Jan 3, 2020 at 8:13 PM Eli Zaretskii <address@hidden> wrote:
> > From: Pip Cet <address@hidden>
> > Date: Fri, 3 Jan 2020 18:53:46 +0000
> > Cc: Philipp Stephani <address@hidden>, address@hidden, address@hidden
> >
> > If I'm reading the test correctly, it depends on garbage-collect
> > actually collecting an unreferenced vector; since our GC's
> > conservative, that might not be working for you, if a word that
> > happens to look like a reference to the vector is still on the stack.
> > (Or it might be something else entirely, but I don't think the test as
> > it stands is correct).
>
> You are probably right, because I see the same failure on GNU/Linux,
> in an x86_64 unoptimized build:

I see it too. Fprogn keeps the value of the first sub-form alive while
evaluating the second one.

We can "fix" Fprogn to discard val early in unoptimized builds, and
that might make GC behavior slightly less surprising.

But it won't properly fix this test.

Attachment: 0001-Make-progn-make-huge-vector-garbage-collect-behave-a.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]