bug#35564: [PATCH v5] Tweak dired warning about "wildcard" characters

[Kévin Le Gouguec]

Hello,

Here is a new revision of this patch series, which aims to rephrase
dired-do-shell-command's warning about occurrences of '?' and '*' that
will not be substituted for filenames, with the following goals in mind:

1. cease to call these characters "wildcards" since they may be quoted
   or escaped,
2. cater to users who do not know about the substitution feature,
3. keep the default prompt as concise as the current one.

The first revisions[1][2][3][4] focused on goals 1 and 2, to the
detriment of 3.  The last revision[5] hid the verbosity behind an
optional explanatory buffer, using read-multiple-choice.  Since this
function already generates a help buffer bound to '?', I bound the
explanatory buffer to 'd' for "details", a la nsm-query-user.

Juri suggested[6] that read-char-from-minibuffer might fit the bill
better.  Since I feel kind of torn between these options, I'm putting
them both forward.

First, the scaffolding patches (same as v5):

0001-Tweak-dired-warning-about-wildcard-characters.patch
Description: Text Data

0002-Dedup-dired-aux-isolated-char-searching-Bug-35564.patch
Description: Text Data

0003-Add-markers-below-non-isolated-chars-in-dired-prompt.patch
Description: Text Data

0004-Simplify-highlighting-assertions.patch
Description: Text Data

Then, the patch adding read-multiple-choice (mostly the same as v5):

0005-Hide-detailed-explanations-in-a-togglable-help-buffe-rmc.patch
Description: Text Data

Or, the patch adding read-char-from-minibuffer:

0005-Hide-detailed-explanations-in-a-togglable-help-buffe-rcfm.patch
Description: Text Data

Squashed patches:

0001-Tweak-dired-warning-about-wildcard-characters-rmc-squashed.patch
Description: Text Data

0001-Tweak-dired-warning-about-wildcard-characters-rcfm-squashed.patch
Description: Text Data

For reference, here is the diff between both the read-multiple-choice
and the read-char-from-minibuffer options:

rmc-vs-rcfm.patch
Description: Text Data

Once applied, the patches can be tried out by

- opening a Dired buffer,
- hitting '!',
- inputting e.g. "sed 's/?/!/'".


WDYT?


Thank you for your time.


[1] bug#35564#5
[2] bug#35564#38
[3] bug#35564#62
[4] bug#35564#101
[5] bug#35564#157
[6] bug#35564#187