[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#32672: 27.0.50; image resize on window resizing
From: |
Juri Linkov |
Subject: |
bug#32672: 27.0.50; image resize on window resizing |
Date: |
Wed, 27 Nov 2019 23:53:46 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) |
tags 32672 fixed
close 32672 27.0.50
quit
>> Using new hooks I noticed only one problem that when the same image buffer is
>> displayed in several windows then using `other-window' to switch between
>> them,
>> the selection-change hook is not always called.
>
> [...]
>
>> + (add-hook 'window-size-change-functions (debounce #'image-window-change
>> 1) nil t)
>> + (add-hook 'window-state-change-functions (debounce
>> #'image-window-change 1) nil t)
>> + (add-hook 'window-selection-change-functions (debounce
>> #'image-window-change 1) nil t)
>> +
>
> I think this sounds like a nice addition for image-mode... but were the
> remaining edge cases ever resolved? I see that the patch hasn't been
> applied.
This is installed now with the following patch and closed.
diff --git a/lisp/image-mode.el b/lisp/image-mode.el
index db6864649d..09d7828047 100644
--- a/lisp/image-mode.el
+++ b/lisp/image-mode.el
@@ -599,6 +599,10 @@ image-mode--setup-mode
(add-hook 'change-major-mode-hook #'image-toggle-display-text nil t)
(add-hook 'after-revert-hook #'image-after-revert-hook nil t)
+ (add-hook 'window-size-change-functions #'image--window-change nil t)
+ (add-hook 'window-state-change-functions #'image--window-change nil t)
+ (add-hook 'window-selection-change-functions #'image--window-change nil t)
+
(run-mode-hooks 'image-mode-hook)
(let ((image (image-get-display-property))
(msg1 (substitute-command-keys
@@ -856,6 +860,27 @@ image-after-revert-hook
(get-buffer-window-list (current-buffer) 'nomini 'visible))
(image-toggle-display-image)))
+(defvar image--window-change-function
+ (debounce 1.0
+ (lambda (window)
+ (when (window-live-p window)
+ (with-current-buffer (window-buffer)
+ (when (derived-mode-p 'image-mode)
+ (let ((spec (image-get-display-property)))
+ (when (eq (car-safe spec) 'image)
+ (let* ((image-width (plist-get (cdr spec) :max-width))
+ (image-height (plist-get (cdr spec) :max-height))
+ (edges (window-inside-pixel-edges window))
+ (window-width (- (nth 2 edges) (nth 0 edges)))
+ (window-height (- (nth 3 edges) (nth 1 edges))))
+ (when (and image-width image-height
+ (or (not (= image-width window-width))
+ (not (= image-height window-height))))
+ (image-toggle-display-image)))))))))))
+
+(defun image--window-change (window)
+ (funcall image--window-change-function window))
+
;;; Animated images
- bug#32672: 27.0.50; image resize on window resizing,
Juri Linkov <=