[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#22860: [PATCH] vc-hg: prompt for branch to merge
From: |
Andrii Kolomoiets |
Subject: |
bug#22860: [PATCH] vc-hg: prompt for branch to merge |
Date: |
Sat, 23 Nov 2019 20:51:28 +0200 |
On 23 Nov 2019, at 20:34, Eli Zaretskii <eliz@gnu.org> wrote:
>
>> +*** The Hg (Mercurial) back-end now use tag and branch names instead of
>> +revision numbers as completion candidates on reading revision.
>
> Why "instead of revision numbers"? it sounds like a backward
> incompatible change. Can't we use both revision numbers and
> branch/tag names?
You are right, it's backward incompatible. And yes, revision numbers can
be used with branch/tag names. But they should not. It was big surprise
for me to see numbers from 0 to 116K as completion candidates on
vc-retrieve-tag. IMO revision numbers are useles in completions.
>> (defun vc-hg-merge-branch ()
>> - "Merge incoming changes into the current working directory.
>> + "Prompts for branch and merge it into the current branch.
>
> "Prompt", not "prompts", for consistency with how we word our doc
> strings for functions.
Fixed.
0001-vc-hg-prompt-for-branch-to-merge.patch
Description: Binary data
- bug#22860: [PATCH] vc-hg: prompt for branch to merge, Andrii Kolomoiets, 2019/11/23
- bug#22860: [PATCH] vc-hg: prompt for branch to merge, Eli Zaretskii, 2019/11/23
- bug#22860: [PATCH] vc-hg: prompt for branch to merge,
Andrii Kolomoiets <=
- bug#22860: [PATCH] vc-hg: prompt for branch to merge, Eli Zaretskii, 2019/11/23
- bug#22860: [PATCH] vc-hg: prompt for branch to merge, Andrii Kolomoiets, 2019/11/23
- bug#22860: [PATCH] vc-hg: prompt for branch to merge, Dmitry Gutov, 2019/11/25
- bug#22860: [PATCH] vc-hg: prompt for branch to merge, Andrii Kolomoiets, 2019/11/25
- bug#22860: [PATCH] vc-hg: prompt for branch to merge, Dmitry Gutov, 2019/11/25
- bug#22860: [PATCH] vc-hg: prompt for branch to merge, Eli Zaretskii, 2019/11/26
- bug#22860: [PATCH] vc-hg: prompt for branch to merge, Eli Zaretskii, 2019/11/26
- bug#22860: [PATCH] vc-hg: prompt for branch to merge, Andrii Kolomoiets, 2019/11/26
- bug#22860: [PATCH] vc-hg: prompt for branch to merge, Eli Zaretskii, 2019/11/30