|
From: | Paul Eggert |
Subject: | bug#37659: Mattias Engdegård <mattiase <at> acm.org> |
Date: | Fri, 11 Oct 2019 16:07:25 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 |
Thanks for the proposed patch. Two thoughts:1. Instead of the symbol 'unordered-or' (which is remarkably hard to read), I suggest using the ASCII letter 'V'. This ASCIIfies the Unicode symbol U+2228 LOGICAL OR (∨). If you prefer, you could make the Unicode symbol an alias for 'V', or use lower-case ASCII 'v', or whatever. The point is that '(unordered-or A B)' is too hard to read with all those 'or's in there.
2. Re this patch:
- ((or 'anychar 'anything) (rx--translate-form '(or nonl "\n"))) + ((or 'anychar 'anything) (cons (list "[^z-a]") t))
Is there a reason this uses (cons (list "[^z-a]") t) rather than '(("[^z-a]") . t) ? I realize neighboring code does something similar, but it's not clear to me why it's important to construct new objects here instead of using literals.
[Prev in Thread] | Current Thread | [Next in Thread] |