[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#37515: 27.0.50; button.el doesn't support help-echo function
|
From: |
Basil L. Contovounesios |
|
Subject: |
bug#37515: 27.0.50; button.el doesn't support help-echo function |
|
Date: |
Fri, 04 Oct 2019 00:00:06 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
"Basil L. Contovounesios" <contovob@tcd.ie> writes:
> Lars Ingebrigtsen <larsi@gnus.org> writes:
>
>> "Basil L. Contovounesios" <contovob@tcd.ie> writes:
>>
>>> Some further changes are needed to fully support the help-echo property.
>>> Firstly, help-echo functions expect an overlay as their second argument
>>> when the object that had the property is an overlay (button). Secondly,
>>> help-echo values can be forms in addition to strings and functions.
>>> Lastly, (info "(elisp) Button Properties") needs updating to reflect the
>>> supported values of the help-echo button property.
>>>
>>> The following patch should do all this. I will push it in the next few
>>> days if there are no objections. WDYT?
>>
>> Looks good to me.
>
> Thanks! (The updated patch I just sent merely extends the tests.)
Now pushed to master:
Further improve button.el support for help-echo
0fc8177414 2019-10-03 23:05:14 +0100
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=0fc8177414801e428ca184e8a9ba8b79a291c15a
Thanks,
--
Basil