[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#35504: 26.2; Key `g' should run `package-menu-refresh' in the *Packa
From: |
Basil L. Contovounesios |
Subject: |
bug#35504: 26.2; Key `g' should run `package-menu-refresh' in the *Packages* buffer |
Date: |
Thu, 03 Oct 2019 02:53:54 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
Stefan Kangas <stefan@marxist.se> writes:
> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>
>> > I also agree. How about the attached patch?
>>
>> Fine by me. I wonder, tho: why not set revert-buffer-function and then
>> redefine `package-menu-refresh` as an obsolete alias for `revert-buffer`?
>
> Sure, I've tried to do that in the attached patch. WDYT?
In addition to Stefan M.'s comments, I just noticed a couple of nits:
> -(defun package-menu-refresh ()
> +(defun package-menu-revert (&optional arg noconfirm)
If the arguments aren't used, they should be prefixed with underscores.
> "In Package Menu, download the Emacs Lisp package archive.
> Fetch the contents of each archive specified in
> `package-archives', and then refresh the package menu. Signal a
> -user-error if there is already a refresh running asynchronously."
> +user-error if there is already a refresh running asynchronously.
> +
> +`package-menu-mode' sets ‘revert-buffer-function’ to this
> +function. The args ARG and NOCONFIRM, passed from
> +‘revert-buffer’, are ignored."
revert-buffer-function and revert-buffer are quoted with curly single
quotes instead of the usual grave+apostrophe.
Thanks,
--
Basil