[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#37189: *** GMX Spamverdacht *** Re: bug#37189: Acknowledgement (25.4
From: |
Eli Zaretskii |
Subject: |
bug#37189: *** GMX Spamverdacht *** Re: bug#37189: Acknowledgement (25.4.1: vc-hg-ignore implementation is missing) |
Date: |
Wed, 28 Aug 2019 09:16:36 +0300 |
> Cc: 37189@debbugs.gnu.org
> From: Wolfgang Scherer <Wolfgang.Scherer@gmx.de>
> Date: Wed, 28 Aug 2019 03:46:53 +0200
>
> >> +(defun vc-hg-ignore (file &optional directory remove)
> >> + "Ignore FILE of DIRECTORY (default is `default-directory').
> >> +
> >> +FILE is a file wildcard, relative to the root directory of DIRECTORY.
> > I think instead of "root directory of DIRECTORY" this should say "the
> > top-level directory of DIRECTORY's repository".
> I disagree. This comment is a modified version of the comment for
> `vc-default-ignore'. And the exact same phrase also pops up for
> `vc-svn-ignore':
But do you agree that the alternative text I proposed is more accurate
and more clear? If so, we might wish to change all those places to
use the better wording. It could be a separate commit, of course.