[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#21867: 25.0.50; lossage's log doesn't treat characters read by read-
From: |
Stefan Monnier |
Subject: |
bug#21867: 25.0.50; lossage's log doesn't treat characters read by read-char as separate commands |
Date: |
Fri, 02 Aug 2019 16:16:37 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
> retry:
> do
> - val = read_char (0, Qnil, (input_method ? Qnil : Qt), 0,
> - NUMBERP (seconds) ? &end_time : NULL);
> + {
> + val = read_char (0, Qnil, (input_method ? Qnil : Qt), 0,
> + NUMBERP (seconds) ? &end_time : NULL);
> + record_char (Qnon_command_character);
> + }
Currently, the view-lossage doesn't actually say
`a C-h l` resulted in running view-lossage
contrarily to what Lars seems to assume (and I guess, contrarily to
what the display suggests). Instead it just says
we saw `a` then `C-h` then `l` then view-lossage was run
I think considering this problem as specific to `read-char` is kinda wrong
(after all, `read-char` can be called as part of input-decode-map in
which case the event still very much belongs to "the events that resulted
in running a particular command"; this happens for example for
mouse-clicks in xterm-mouse-mode).
So I think maybe a better way to look at it is to add marker
pseudo-events like `end-of-command` (e.g. after running
post-command-hook), so we can discover that `a` was processed as part of
the execution of the command bound to `C-x C-e` rather than as part of
the sequence of events that triggered view-lossage.
Stefan
- bug#21867: 25.0.50; lossage's log doesn't treat characters read by read-char as separate commands, Lars Ingebrigtsen, 2019/08/01
- bug#21867: 25.0.50; lossage's log doesn't treat characters read by read-char as separate commands, Eli Zaretskii, 2019/08/01
- bug#21867: 25.0.50; lossage's log doesn't treat characters read by read-char as separate commands, Lars Ingebrigtsen, 2019/08/01
- bug#21867: 25.0.50; lossage's log doesn't treat characters read by read-char as separate commands, Eli Zaretskii, 2019/08/01
- bug#21867: 25.0.50; lossage's log doesn't treat characters read by read-char as separate commands, Lars Ingebrigtsen, 2019/08/01
- bug#21867: 25.0.50; lossage's log doesn't treat characters read by read-char as separate commands, Eli Zaretskii, 2019/08/01
- bug#21867: 25.0.50; lossage's log doesn't treat characters read by read-char as separate commands, Lars Ingebrigtsen, 2019/08/01
- bug#21867: 25.0.50; lossage's log doesn't treat characters read by read-char as separate commands, Eli Zaretskii, 2019/08/02
- bug#21867: 25.0.50; lossage's log doesn't treat characters read by read-char as separate commands, Lars Ingebrigtsen, 2019/08/02
- bug#21867: 25.0.50; lossage's log doesn't treat characters read by read-char as separate commands, Eli Zaretskii, 2019/08/02
- bug#21867: 25.0.50; lossage's log doesn't treat characters read by read-char as separate commands,
Stefan Monnier <=
- bug#21867: 25.0.50; lossage's log doesn't treat characters read by read-char as separate commands, Lars Ingebrigtsen, 2019/08/03
- bug#21867: 25.0.50; lossage's log doesn't treat characters read by read-char as separate commands, Stefan Monnier, 2019/08/03
- bug#21867: 25.0.50; lossage's log doesn't treat characters read by read-char as separate commands, Lars Ingebrigtsen, 2019/08/03
- bug#21867: 25.0.50; lossage's log doesn't treat characters read by read-char as separate commands, Juri Linkov, 2019/08/03
- bug#21867: 25.0.50; lossage's log doesn't treat characters read by read-char as separate commands, Lars Ingebrigtsen, 2019/08/04
- bug#21867: 25.0.50; lossage's log doesn't treat characters read by read-char as separate commands, Juri Linkov, 2019/08/04
- bug#21867: 25.0.50; lossage's log doesn't treat characters read by read-char as separate commands, Stefan Monnier, 2019/08/04
- bug#21867: 25.0.50; lossage's log doesn't treat characters read by read-char as separate commands, Juri Linkov, 2019/08/04
- bug#21867: 25.0.50; lossage's log doesn't treat characters read by read-char as separate commands, Stefan Monnier, 2019/08/05
- bug#21867: 25.0.50; lossage's log doesn't treat characters read by read-char as separate commands, Lars Ingebrigtsen, 2019/08/07