bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#27807: 25.2; ido-completing-read handles cons-style initial-input wr


From: Lars Ingebrigtsen
Subject: bug#27807: 25.2; ido-completing-read handles cons-style initial-input wrong
Date: Mon, 15 Jul 2019 20:54:03 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

Ryan <address@hidden> writes:

>> `completing-read' uses 0-based index while `read-from-minibuffer' uses
>> 1-based index.
>
> Looking at "ido-read-internal", it passes the inital-input argument
> directly to "read-from-minibuffer" without incrementing it as
> "completing-read-default" does. Therefore any initial input of the form
> "(STRING . POSITION)" is handled incorrectly by ido, but this can be
> fixed by copying over the logic from "completing-read-default", as in
> this patch:
> https://mneme.dedyn.io/zerobin/?7cd07d73217c68e5#Aynth3YcZDcE7bkq8cxQnBl+uJ0/+d0UGYmB+7PqLT4=

The link is dead now, but I think I've now fixed this for Emacs 27.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





reply via email to

[Prev in Thread] Current Thread [Next in Thread]