[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#30515: 26.0; `mouse-1' in Profiler report

From: Lars Ingebrigtsen
Subject: bug#30515: 26.0; `mouse-1' in Profiler report
Date: Sun, 14 Jul 2019 18:21:59 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

Drew Adams <address@hidden> writes:

> In the output of `profiler-report', `mouse-1' does not respect option
> `mouse-1-click-follows-link'.

The patch below seems to fix this (and works with
mouse-1-click-follows-link both nil or not.

But is this really the way to do this stuff these days?  It seems so...

diff --git a/lisp/profiler.el b/lisp/profiler.el
index 775096276d..ee11ff68c5 100644
--- a/lisp/profiler.el
+++ b/lisp/profiler.el
@@ -473,6 +473,7 @@ profiler-report-make-entry-part
                       (fboundp entry))
                  (propertize (symbol-name entry)
                              'face 'link
+                              'follow-link "\r"
                              'mouse-face 'highlight
                              'help-echo "\
 mouse-2: jump to definition\n\
@@ -534,9 +535,9 @@ profiler-report-mode-map
     (define-key map "\r"    'profiler-report-toggle-entry)
     (define-key map "\t"    'profiler-report-toggle-entry)
     (define-key map "i"     'profiler-report-toggle-entry)
-    (define-key map [mouse-1] 'profiler-report-toggle-entry)
     (define-key map "f"     'profiler-report-find-entry)
     (define-key map "j"     'profiler-report-find-entry)
+    (define-key map [follow-link] 'mouse-face)
     (define-key map [mouse-2] 'profiler-report-find-entry)
     (define-key map "d"            'profiler-report-describe-entry)
     (define-key map "C"            'profiler-report-render-calltree)

(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

reply via email to

[Prev in Thread] Current Thread [Next in Thread]