bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#33076: 26; `read-only-mode' messages


From: Lars Ingebrigtsen
Subject: bug#33076: 26; `read-only-mode' messages
Date: Wed, 10 Jul 2019 15:54:40 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

Drew Adams <address@hidden> writes:

> It would be much clearer if the messages referred to the buffer by name,
> rather than just "current buffer".  You can use `C-x C-q' in the
> selected window even when the buffer might not be clearly displayed
> (e.g. tiny or partly obscured window/frame).  Having the message tell
> you which buffer you changed read-only for provides better confirmation.

(and "in current buffer" should perhaps have a "the" in it anyway?)

This is output by the define-minor-mode machinery:

           (if (called-interactively-p 'any)
               (progn
                 ,(if (and globalp (not variable))
                      `(customize-mark-as-set ',mode))
                 ;; Avoid overwriting a message shown by the body,
                 ;; but do overwrite previous messages.
                 (unless (and (current-message)
                              (not (equal ,last-message
                                          (current-message))))
                   (let ((local ,(if globalp "" " in current buffer")))
                     (message ,(format "%s %%sabled%%s" pretty-name)
                              (if ,getter "en" "dis") local)))))

So it looks easy enough to change, but it's a change that would affect
all minor mode.  Do we want all interactive minor modes to message the
buffer names?  I don't know what I think of it myself.

Perhaps mainly because some buffer names are so long that this would
increase the echo area sometimes, which is slightly annoying.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





reply via email to

[Prev in Thread] Current Thread [Next in Thread]