bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#33516: Should the docstring for flymake-diag-region mention behavior


From: Lars Ingebrigtsen
Subject: bug#33516: Should the docstring for flymake-diag-region mention behavior with narrowing?
Date: Wed, 10 Jul 2019 01:48:45 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

Matthew Bregg <address@hidden> writes:

> Currently it can be confusing when developing a flymake checker that
> flymake-diag-region does not handle narrowing.
>
> Updating the comment to mention this seems useful to me.

[...]

> -region is invalid."
> +region is invalid.
> +If the BUFFER has been narrowed,
> +the region returned will correspond to the BUFFER's narrowed state."

Hm...  I think we generally assume that all functions (except explicitly
documented not to) work on the narrowed section of a buffer?  So
documenting this in this specific function doesn't seem natural do me,
and I'm closing this bug report.  If somebody disagrees, please reopen.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





reply via email to

[Prev in Thread] Current Thread [Next in Thread]