[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#20845: 25.0.50; bookmark.el, handling of fictitious `buffer' propert
bug#20845: 25.0.50; bookmark.el, handling of fictitious `buffer' property
Fri, 5 Jul 2019 16:04:36 +0200
Stefan Monnier <address@hidden> writes:
> > I'm looking into Emacs Bug#20845 which asks about the purpose of the
> > "bookmark" property in bookmark.el.
> I don't see any `bookmark` property, sorry.
That should be "buffer", sorry about that.
> > The suggestion given by Drew above is to remove it.
> > Do you have an opinion about that?
> Not really, no. But such "old-style" bookmarks might still be used by
> third-party packages and might still appear in users's
> ~/.emacs.d/bookmarks, so if we want to remove support for it, maybe we
> should try and do it gradually.
> [...taking a second look...]
> Oh, I see how/where it's used and it's definitely still used:
> Info-bookmark-jump uses it (i.e. not in the stored bookmark object, but
> in a transient object passed to bookmark-default-handler).
> So maybe it should be documented in the docstring of
> `bookmark-default-handler` for the benefit of other handlers.
I agree with this conclusion. So not only do we keep it, but we document it.
Thanks for helping out Stefan, it seems we now have a way forward.