bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#36485: [PATCH] Improve some menus with separators and better wording


From: Eli Zaretskii
Subject: bug#36485: [PATCH] Improve some menus with separators and better wording
Date: Wed, 03 Jul 2019 13:40:29 +0300

> From: Stefan Kangas <stefan@marxist.se>
> Date: Wed, 3 Jul 2019 09:17:42 +0200
> 
> Just a small patch to add menu separators to some menus that are
> missing them.

What were the criteria for determining that a separator is missing in
a particular place?

Adding separators makes the menus longer, which could be a problem,
especially on TTY frames with a small number of lines (like 24).  So
we need to add them judiciously.

>      ["Previous Topic" help-go-back
> -     :help "Go back to previous topic in this help buffer"]
> +     :help "Go back to previously visited topic"]
>      ["Next Topic" help-go-forward
> -     :help "Go back to next topic in this help buffer"]
> +     :help "Go back to next visited topic"]

These changes lose information, because there could be more than on
Info buffer in an Emacs session.  Any particular reason you thought we
should remove the "this help buffer" part?

>      (easy-menu-define nil map ""
>        '("Eww"
> -     ["Exit" quit-window t]
>       ["Close browser" quit-window t]

Why did you want to remove the "Exit" item?

Thanks.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]