[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#35564: [PATCH v3] Tweak dired warning about "wildcard" characters
From: |
Kévin Le Gouguec |
Subject: |
bug#35564: [PATCH v3] Tweak dired warning about "wildcard" characters |
Date: |
Fri, 28 Jun 2019 08:15:44 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
Noam Postavsky <npostavs@gmail.com> writes:
> Yes, this was kind of bugging me, so here's a patch to reuse that logic
> (it applies on top of yours). While doing this I noticed that we
> earlier missed that `*` is not considered isolated, unlike `?`.
Thank you very much!
> Assuming no problems, I'll just push your two patches followed by mine
Fine by me, although it just occurs to me that I forgot to mention the
bug number in my commit messages. Here are updated patches:
0001-Preserve-text-properties-in-y-or-n-p-prompts.patch
Description: Text Data
0002-Tweak-dired-warning-about-wildcard-characters.patch
Description: Text Data
> +(defun dired--no-subst-prompt (command char-positions)
> […]
> + ((setq confirmations (dired--need-confirm-positions command
> "*"))
> + (y-or-n-p (dired--no-subst-prompt confirmations command)))
> + ((setq confirmations (dired--need-confirm-positions command
> "?"))
> + (y-or-n-p (dired--no-subst-prompt command confirmations)))
Mmmm, am I missing something, or have the arguments to
dired--no-subst-prompt been reversed in the "*" case? I.e. shoudn't
> + (y-or-n-p (dired--no-subst-prompt confirmations command)))
rather be
> + (y-or-n-p (dired--no-subst-prompt command confirmations)))
? As things stand, "! grep 'foo.*'" in Dired fails, saying:
let: Wrong type argument: stringp, (9)
- bug#35564: [PATCH v2] Tweak dired warning about "wildcard" characters, (continued)
bug#35564: [PATCH v3] Tweak dired warning about "wildcard" characters, Kévin Le Gouguec, 2019/06/26
- bug#35564: [PATCH v3] Tweak dired warning about "wildcard" characters, Drew Adams, 2019/06/26
- bug#35564: [PATCH v3] Tweak dired warning about "wildcard" characters, Stefan Monnier, 2019/06/26
- bug#35564: [PATCH v3] Tweak dired warning about "wildcard" characters, Noam Postavsky, 2019/06/27
- bug#35564: [PATCH v3] Tweak dired warning about "wildcard" characters,
Kévin Le Gouguec <=
- bug#35564: [PATCH v3] Tweak dired warning about "wildcard" characters, Drew Adams, 2019/06/28
- bug#35564: [PATCH v3] Tweak dired warning about "wildcard" characters, Kévin Le Gouguec, 2019/06/28
- bug#35564: [PATCH v3] Tweak dired warning about "wildcard" characters, Drew Adams, 2019/06/28
- bug#35564: [PATCH v3] Tweak dired warning about "wildcard" characters, Noam Postavsky, 2019/06/29
- bug#35564: [PATCH v3] Tweak dired warning about "wildcard" characters, Drew Adams, 2019/06/29
- bug#35564: [PATCH v3] Tweak dired warning about "wildcard" characters, Eli Zaretskii, 2019/06/29