[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#11605: 24.1.50; vc-ediff revert annoyance
From: |
Lars Ingebrigtsen |
Subject: |
bug#11605: 24.1.50; vc-ediff revert annoyance |
Date: |
Thu, 27 Jun 2019 17:16:21 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
Dmitry Gutov <dgutov@yandex.ru> writes:
>>> (with-current-buffer result-buf
>>> ;; Set the parent buffer so that things like
>>> ;; C-x v g, C-x v l, ... etc work.
>>> - (set (make-local-variable 'vc-parent-buffer) filebuf))
>>> + (set (make-local-variable 'vc-parent-buffer) filebuf)
>>> + (revert-buffer nil t))
>
> It seems like this might conflict with other uses of vc-find-revision,
> like vc-revision-other-window. Where the user is allowed to change the
> contents of the returned buffer, and might've done so before we do
> this automatic silent revert.
>
> Maybe do it on ediff's side instead?
Yeah, after poking at this a bit more, I agree -- ediff should set up
this better, and just calling revert in the vc functions does not seem
to be the logical choice.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- bug#11605: 24.1.50; vc-ediff revert annoyance,
Lars Ingebrigtsen <=