[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#36167: [PATCH] Replace [0-9a-fA-F] with [[:xdigit:]]
From: |
Robert Pluim |
Subject: |
bug#36167: [PATCH] Replace [0-9a-fA-F] with [[:xdigit:]] |
Date: |
Tue, 11 Jun 2019 15:30:48 +0200 |
>>>>> On Tue, 11 Jun 2019 16:17:10 +0300, Konstantin Kharlamov
>>>>> <hi-angel@yandex.ru> said:
Konstantin> * etc/schema/od-schema-v1.2-os.rnc: replace
Konstantin> [0-9a-fA-F] with [[:xdigit:]]
>>
>> This is the org schema file for OpenDocument export, not emacs
>> lisp. Does that support :xdigit: syntax?
Konstantin> Oh, okay, thanks, I couldn't figure out what it is because
Wikipedia
Konstantin> says that .rnc is just a variation of XML, and README just says
it's
Konstantin> something to map some xml schemas to documents. So I deemed
these
Konstantin> regexps are too used by ELisp.
Konstantin> Can I test it somehow? Either way, not a big deal, I can just
drop
Konstantin> that one.
If I remember correctly, the schema is copied into the resulting
OpenDocument file, so itʼs probably safest not to touch it.
Konstantin> * lisp/calc/calc-aent.el: replace [0-9a-fA-F] with
Konstantin> [[:xdigit:]]
>>
>> Normally, you'd mention the containing function in the ChangeLog
>> entry. Using 'C-x 4 a' (ie 'add-change-log-entry-other-window') with
>> point on the code youʼre changing does that for you.
Konstantin> Ah, thanks. At this point I'll probably ask on emacs-devel about
Konstantin> adding to prepare-commit-msg a code to pre-format the changes,
because
Konstantin> clearly that's a lot of manual work for something that should be
Konstantin> automated.
Itʼs pretty automated:
- Do M-x vc-dir in your emacs repository to see which files are changed
- Do C-x 4 a to prepare the ChangeLog entries
- Mark the files you want you commit
- Commit from the vc-dir buffer. This will copy the earlier ChangeLog
entries into the commit message buffer
Unless you meant completely automatically generating the ChangeLog
entries, which is a wholly different can of worms.
Robert
- bug#36167: [PATCH] Replace manually crafted hex regexes with [[:xdigit:]], Konstantin Kharlamov, 2019/06/11
- bug#36167: Acknowledgement ([PATCH] Replace manually crafted hex regexes with [[:xdigit:]]), Konstantin Kharlamov, 2019/06/11
- bug#36167: [PATCH] Replace [0-9a-fA-F] with [[:xdigit:]], Konstantin Kharlamov, 2019/06/11
- bug#36167: [PATCH] Replace [0-9a-fA-F] with [[:xdigit:]], Robert Pluim, 2019/06/11
- bug#36167: [PATCH] Replace [0-9a-fA-F] with [[:xdigit:]], Konstantin Kharlamov, 2019/06/11
- bug#36167: [PATCH] Replace [0-9a-fA-F] with [[:xdigit:]],
Robert Pluim <=
- bug#36167: [PATCH] Replace [0-9a-fA-F] with [[:xdigit:]], Konstantin Kharlamov, 2019/06/11
- bug#36167: [PATCH] Replace [0-9a-fA-F] with [[:xdigit:]], Eli Zaretskii, 2019/06/11
- bug#36167: [PATCH] Replace [0-9a-fA-F] with [[:xdigit:]], Robert Pluim, 2019/06/12
- bug#36167: [PATCH] Replace [0-9a-fA-F] with [[:xdigit:]], Konstantin Kharlamov, 2019/06/12
- bug#36167: [PATCH] Replace [0-9a-fA-F] with [[:xdigit:]], Eli Zaretskii, 2019/06/12
- bug#36167: [PATCH] Replace [0-9a-fA-F] with [[:xdigit:]], Konstantin Kharlamov, 2019/06/12
- bug#36167: [PATCH] Replace [0-9a-fA-F] with [[:xdigit:]], Eli Zaretskii, 2019/06/12
- bug#36167: [PATCH] Replace [0-9a-fA-F] with [[:xdigit:]], Konstantin Kharlamov, 2019/06/12
- bug#36167: [PATCH] Replace [0-9a-fA-F] with [[:xdigit:]], Lars Ingebrigtsen, 2019/06/12
- bug#36167: [PATCH] Replace [0-9a-fA-F] with [[:xdigit:]], Lars Ingebrigtsen, 2019/06/12